Reviewers: jochen (slow),
Message:
ptal
Description:
Parser: Removing debug code.
The mystery crash never reappeared once the debugging code was in place.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/760863003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -13 lines):
M src/parser.h
M src/parser.cc
Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index
22c0f5c142c918cc45043fc1b11efb6f4a46488d..83fb594bb021395d593cbde5a9d36cbb6ec3f925
100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -835,7 +835,6 @@ FunctionLiteral* Parser::ParseProgram() {
// Initialize parser state.
CompleteParserRecorder recorder;
- debug_saved_compile_options_ = compile_options();
if (produce_cached_parse_data()) {
log_ = &recorder;
} else if (consume_cached_parse_data()) {
@@ -3828,13 +3827,6 @@ void Parser::SkipLazyFunctionBody(const
AstRawString* function_name,
int* materialized_literal_count,
int* expected_property_count,
bool* ok) {
- // Temporary debugging code for tracking down a mystery crash which
should
- // never happen. The crash happens on the line where we log the function
in
- // the preparse data: log_->LogFunction(...). TODO(marja): remove this
once
- // done.
- CHECK(materialized_literal_count);
- CHECK(expected_property_count);
- CHECK(debug_saved_compile_options_ == compile_options());
if (produce_cached_parse_data()) CHECK(log_);
int function_block_pos = position();
@@ -5148,7 +5140,6 @@ void Parser::ParseOnBackground() {
fni_ = new (zone()) FuncNameInferrer(ast_value_factory(), zone());
CompleteParserRecorder recorder;
- debug_saved_compile_options_ = compile_options();
if (produce_cached_parse_data()) log_ = &recorder;
DCHECK(info()->source_stream() != NULL);
Index: src/parser.h
diff --git a/src/parser.h b/src/parser.h
index
23acab6ff6b42f9ca81be7469d98eaa557ddd756..4d60272497cebbb264aec0de1794fbd1603b75ed
100644
--- a/src/parser.h
+++ b/src/parser.h
@@ -907,10 +907,6 @@ class Parser : public ParserBase<ParserTraits> {
int use_counts_[v8::Isolate::kUseCounterFeatureCount];
int total_preparse_skipped_;
HistogramTimer* pre_parse_timer_;
-
- // Temporary; for debugging. See Parser::SkipLazyFunctionBody.
TODO(marja):
- // remove this once done.
- ScriptCompiler::CompileOptions debug_saved_compile_options_;
};
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
