LGTM, and congratulations, you just inherited all bugs that have to do with
the
weak transitive closure not being complete. :)
https://codereview.chromium.org/761343004/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/761343004/diff/20001/src/heap/mark-compact.cc#newcode2208
src/heap/mark-compact.cc:2208: // reachable only from weak global
handles.
nit: This dangling part of the sentence looks like a left-over, can we
drop it?
https://codereview.chromium.org/761343004/diff/20001/src/heap/mark-compact.cc#newcode2218
src/heap/mark-compact.cc:2218: // the weak roots we just marked as
pending destruction.
This requires more explanation as to why we can skip other
embedder-specific marking here, e.g. all objects groups have been fully
processed and no weakly reachable node can discover new object groups.
https://codereview.chromium.org/761343004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
