Reviewers: Christian Plesner Hansen, Description: Implement ES5 Array.isArray
Please review this at http://codereview.chromium.org/271072 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/array.js A test/mjsunit/third_party/array-isarray.js Index: test/mjsunit/third_party/array-isarray.js =================================================================== --- test/mjsunit/third_party/array-isarray.js (revision 0) +++ test/mjsunit/third_party/array-isarray.js (revision 0) @@ -0,0 +1,48 @@ +// Copyright (c) 2009 Apple Computer, Inc. All rights reserved. +// +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions +// are met: +// +// 1. Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// +// 2. Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// +// 3. Neither the name of the copyright holder(s) nor the names of any +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS +// FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE +// COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, +// INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES +// (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR +// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) +// HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, +// STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) +// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED +// OF THE POSSIBILITY OF SUCH DAMAGE. + +// Based on LayoutTests/fast/js/resources/Array-isArray.js + +assertTrue(Array.isArray([])); +assertTrue(Array.isArray(new Array)); +assertTrue(Array.isArray(Array())); +assertTrue(Array.isArray('abc'.match(/(a)*/g))); +assertFalse((function(){ return Array.isArray(arguments); })()); +assertFalse(Array.isArray()); +assertFalse(Array.isArray(null)); +assertFalse(Array.isArray(undefined)); +assertFalse(Array.isArray(true)); +assertFalse(Array.isArray(false)); +assertFalse(Array.isArray('a string')); +assertFalse(Array.isArray({})); +assertFalse(Array.isArray({length: 5})); +assertFalse(Array.isArray({__proto__: Array.prototype, length:1, 0:1, 1:2})); + Index: src/array.js =================================================================== --- src/array.js (revision 3056) +++ src/array.js (working copy) @@ -1058,6 +1058,10 @@ return current; } +// ES5, 15.4.3.2 +function ArrayIsArray(obj) { + return IS_ARRAY(obj); +} // ------------------------------------------------------------------- @@ -1075,6 +1079,11 @@ // object. %SetProperty($Array.prototype, "constructor", $Array, DONT_ENUM); + // Setup non-enumerable functions on the Array object. + InstallFunctions($Array, DONT_ENUM, $Array( + "isArray", ArrayIsArray + )); + // Setup non-enumerable functions of the Array.prototype object and // set their names. InstallFunctionsOnHiddenPrototype($Array.prototype, DONT_ENUM, $Array( @@ -1098,8 +1107,9 @@ "indexOf", ArrayIndexOf, "lastIndexOf", ArrayLastIndexOf, "reduce", ArrayReduce, - "reduceRight", ArrayReduceRight)); - + "reduceRight", ArrayReduceRight + )); + // Manipulate the length of some of the functions to meet // expectations set by ECMA-262 or Mozilla. UpdateFunctionLengths({ --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
