On 2014/12/02 13:58:28, vogelheim wrote:
https://codereview.chromium.org/774613003/diff/1/src/natives-external.cc
File src/natives-external.cc (right):
https://codereview.chromium.org/774613003/diff/1/src/natives-external.cc#newcode84
src/natives-external.cc:84: Vector<const char> NameFromId(const byte* id,
int
id_length) {
On 2014/12/02 12:17:48, Dmitry Lomov (chromium) wrote:
> At least bootstrapper.cc assumes GetScriptName to be 0-terminated
Done.
(That is, the return Vector still doesn't include the 0-byte, but the
underlying
buffer does. Ugh.)
Ugh indeed. As discussed offline, it looks like only bootstrapper relies on
this, so lets fix the bootstrapper instead.
https://codereview.chromium.org/774613003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
