https://codereview.chromium.org/754863002/diff/120001/src/runtime/runtime.h
File src/runtime/runtime.h (right):
https://codereview.chromium.org/754863002/diff/120001/src/runtime/runtime.h#newcode708
src/runtime/runtime.h:708: F(HasFastPackedElements, 1, 1)
On 2014/11/27 07:17:54, Dmitry Lomov (chromium) wrote:
Is it critical for HasFastPackedElements to be INLINE_FUNCTION instead
of
INLINE_OPTIMIZED_FUNCTION (see below, line 718)?
If you use runtime function in full codegen, you will save yourself
from having
to write all those tedious Emit functions in all the ports
Not sure what counts as "critical". Sure, the implementations are a bit
tedious, but they're straightforward enough, so I don't see much point
in penalizing full codegen if I can make them fast.
https://codereview.chromium.org/754863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.