https://codereview.chromium.org/757143002/diff/100001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/757143002/diff/100001/src/hydrogen.cc#newcode12142
src/hydrogen.cc:12142: LoopBuilder loop(this);
On 2014/12/02 21:26:27, Dmitry Lomov (chromium) wrote:
On 2014/12/02 21:00:38, adamk wrote:
> On 2014/11/27 18:18:26, Dmitry Lomov (chromium) wrote:
> > Nit: use RAII for Loop/IfBuilders
>
> Can you explain what you mean here? Do you mean you want more C++
blocks? Or
> something else?
Yes; sorry for being unclear; the pattern is:
{ IfBuilder if(..)
}
etc. You do not need to call End on IfBuilders then
That works on IfBuilders, but LoopBuilder just has a DCHECK(finished_)
in its destructor. I've fixed up my ifs, but left the loop as-is. A
followup patch could change LoopBuilder's behavior, but I'd rather not
touch it in this one.
https://codereview.chromium.org/757143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
