lgtm with nits.
https://codereview.chromium.org/766893002/diff/20001/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/766893002/diff/20001/src/serialize.cc#newcode1467
src/serialize.cc:1467: if (FLAG_trace_serializer) {
I thought it was FLAG_trace_code_serializer?
https://codereview.chromium.org/766893002/diff/20001/src/serialize.cc#newcode2054
src/serialize.cc:2054: if (FLAG_trace_serializer) {
FLAG_trace_serializer or FLAG_trace_code_serializer, either one is fine
so long as it compiles :).
https://codereview.chromium.org/766893002/diff/20001/src/serialize.h
File src/serialize.h (right):
https://codereview.chromium.org/766893002/diff/20001/src/serialize.h#newcode628
src/serialize.h:628: bool SerializeKnownObject(HeapObject* obj,
HowToCode how_to_code,
Can you comment the return value, something like: "returns true if the
object was successfully serialized."
https://codereview.chromium.org/766893002/diff/20001/src/snapshot-source-sink.h
File src/snapshot-source-sink.h (right):
https://codereview.chromium.org/766893002/diff/20001/src/snapshot-source-sink.h#newcode27
src/snapshot-source-sink.h:27: uint8_t Get() {
For simplicity, can the List<byte> below be a List<uint8_t>, or
alternatively, make Get() return byte.
https://codereview.chromium.org/766893002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
