https://codereview.chromium.org/753553002/diff/80001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/753553002/diff/80001/include/v8.h#newcode422
include/v8.h:422: class CallbackData {
nit - BaseCallbackData or maybe even BaseWeakCallbackData?
Would it make sense to put this in a non-public namespace to make it
obvious this isn't intended to be used as part of the external API.
https://codereview.chromium.org/753553002/diff/80001/include/v8.h#newcode435
include/v8.h:435:
nit - two newlines between classes in V8
https://codereview.chromium.org/753553002/diff/80001/include/v8.h#newcode463
include/v8.h:463: : CallbackData<T>(isolate, NULL),
Do we want to expose NULL parameters to PhantomCallbacks - it feels like
that could get error prone if the caller has to know whether to check if
GetParameter() returns null (maybe this is already the case though)?
Would it make sense to have different callbacks for either the internal
field version and the parameter version?
https://codereview.chromium.org/753553002/diff/80001/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/753553002/diff/80001/src/global-handles.cc#newcode662
src/global-handles.cc:662: // We stil need to visit the pointer in case
the object moved,
/s/stil/still
https://codereview.chromium.org/753553002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
