On 2014/12/03 16:22:09, Toon Verwaest wrote:
https://codereview.chromium.org/778673002/diff/1/src/ic/arm64/handler-compiler-arm64.cc
File src/ic/arm64/handler-compiler-arm64.cc (right):
https://codereview.chromium.org/778673002/diff/1/src/ic/arm64/handler-compiler-arm64.cc#newcode73
src/ic/arm64/handler-compiler-arm64.cc:73: __ CmpWeakValue(function, cell,
scratch);
Why still embed the weak cell if all you do is miss if it's different?
We'll
do
a map-check on the prototype itself anyway later on if we use it, so
checking
the function itself is not necessary as far as I can tell.
Good point! The function isn't used later, so we can indeed omit checking
function.
I uploaded new patch set and will change the description.
https://codereview.chromium.org/778673002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
