LGTM with nits.
Please also update the CL description -- there is no
macro "DCHECK_ALWAYS_ON".
It's a bit sad that our own test suite doesn't pass with
dcheck_always_on=1, but
the only solution I can think of is so ugly that I don't like it much
either:
add yet another flag to the test driver, and define special test
expectations. I
guess we'll just stick with running tests in good ol' release and (opt)debug
modes.
https://codereview.chromium.org/760213005/diff/20001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/760213005/diff/20001/src/api.cc#newcode344
src/api.cc:344: #endif // DEBUG
nit: s/DEBUG/VERIFY_HEAP/, again below
https://codereview.chromium.org/760213005/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/760213005/diff/20001/src/objects.h#newcode3081
src/objects.h:3081: #ifdef DEBUG
join this with the above block please
https://codereview.chromium.org/760213005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
