lgtm with some comments (although I am quite unhappy about the hack).
https://codereview.chromium.org/741503006/diff/1/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/741503006/diff/1/src/compiler/js-typed-lowering.cc#newcode133
src/compiler/js-typed-lowering.cc:133: // TODO(jarin): Narrow the type
after patching the operator.
This is not really a big fat TODO. Could you write something like
'Replace the explicit typing hack with a call to some method that
encapsulates changing the operator and re-typing.'?
https://codereview.chromium.org/741503006/diff/1/src/compiler/js-typed-lowering.cc#newcode146
src/compiler/js-typed-lowering.cc:146: }
Insert an empty line here?
https://codereview.chromium.org/741503006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
