Maybe some tests on holey arrays with things on the prototype?
Maybe some tests of typed arrays?
https://codereview.chromium.org/771863002/diff/60001/test/mjsunit/harmony/array-includes-to-object.js
File test/mjsunit/harmony/array-includes-to-object.js (right):
https://codereview.chromium.org/771863002/diff/60001/test/mjsunit/harmony/array-includes-to-object.js#newcode12
test/mjsunit/harmony/array-includes-to-object.js:12: //
Array.prototype.includes should use ToObject on this, so that when
called with a number, it picks up numeric properties from
Number.prototype
Can you add a test that this inside a getter has the right type?
https://codereview.chromium.org/771863002/diff/60001/test/mjsunit/harmony/array-includes.js
File test/mjsunit/harmony/array-includes.js (right):
https://codereview.chromium.org/771863002/diff/60001/test/mjsunit/harmony/array-includes.js#newcode11
test/mjsunit/harmony/array-includes.js:11: //
Nit. We don't use this kind of formatting in other places. Since this is
generated maybe do:
// Array.prototype.includes sees a new element added by a getter that is
hit during iteration
(function() {
https://codereview.chromium.org/771863002/diff/60001/test/mjsunit/harmony/array-includes.js#newcode27
test/mjsunit/harmony/array-includes.js:27:
We use 2 newlines between the test "blocks"
https://codereview.chromium.org/771863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
