LGTM with comments
http://codereview.chromium.org/242034/diff/4005/11003 File test/mjsunit/debug-backtrace.js (right): http://codereview.chromium.org/242034/diff/4005/11003#newcode69 Line 69: return null; you can instead use assertFalse(!!response.body()... below http://codereview.chromium.org/242034/diff/4005/11008 File test/mjsunit/debug-evaluate-recursive.js (right): http://codereview.chromium.org/242034/diff/4005/11008#newcode89 Line 89: testRequest(exec_state, '{"expression":"f()","disable_break":true}', true, 1); long lines: 89,90,92,93 http://codereview.chromium.org/242034/diff/4005/11012 File test/mjsunit/debug-references.js (right): http://codereview.chromium.org/242034/diff/4005/11012#newcode69 Line 69: assertEquals(response.running, dcp.isRunning(), request + ' -> expected not running'); long line http://codereview.chromium.org/242034/diff/4005/11016 File test/mjsunit/debug-suspend.js (right): http://codereview.chromium.org/242034/diff/4005/11016#newcode48 Line 48: function testArguments(exec_state) { please inline or rename this method http://codereview.chromium.org/242034 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
