Nit
https://codereview.chromium.org/756423006/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/756423006/diff/20001/src/hydrogen.cc#newcode12432
src/hydrogen.cc:12432: ast_context()->ReturnValue(result);
On 2014/12/05 15:30:05, arv wrote:
Other places usually do a push/pop in this case but it seems cleaner
to skip
these extra instructions.
Nit: could you keep the push/pop code pattern? This makes it very clear
that only one value is ever returned from this Visit method. (Push/Pop
has no effect on resulting codegen)
https://codereview.chromium.org/756423006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
