Drive by comments.
http://codereview.chromium.org/267077/diff/2001/23 File src/heap-profiler.cc (right): http://codereview.chromium.org/267077/diff/2001/23#newcode587 Line 587: object.ClearWeak(); You probably want to Dispose() the weak handle here. ClearWeak() turns it into a strong handle. http://codereview.chromium.org/267077/diff/2001/23#newcode643 Line 643: GlobalHandles::IterateWeakRoots(PrintProducerStackTrace, StackWeakReferenceCallback); Line too long? http://codereview.chromium.org/267077/diff/2001/23#newcode665 Line 665: HandleScope scope; Persistent handles don't need handle scope. http://codereview.chromium.org/267077/diff/2001/23#newcode666 Line 666: Handle<Object> handle = GlobalHandles::Create(obj); Why not use include/v8.h API here? http://codereview.chromium.org/267077 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
