Reviewers: Toon Verwaest, mvstanton,
Message:
@mvstanton, Toon: please take a look at this tiny followup to
https://codereview.chromium.org/546683003
Alternatively it might be worth simply removing this check, since Context
is a
direct descendant of FixedArray and does not define its own kHeaderSize.
(Found while experimenting with gn + clang + icecc builds.)
Description:
assert kHeaderSize is the same in Context and FixedArray at compile time
The Context::kHeaderSize == FixedArray::kHeaderSize DCHECK can be done
at compile time rather than at runtime in DCHECK-enabled builds.
Please review this at https://codereview.chromium.org/768683006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/code-stubs-hydrogen.cc
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index
fca1e293f8c315f872a0a79143fa70838695d540..f6b20531af9692833fc964d4a791c365ff6bccc9
100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -700,7 +700,7 @@ HValue*
CodeStubGraphBuilder<KeyedLoadSloppyArgumentsStub>::BuildCodeStub() {
HValue* the_context =
Add<HLoadKeyed>(elements, graph()->GetConstant0(),
static_cast<HValue*>(NULL), FAST_ELEMENTS);
- DCHECK(Context::kHeaderSize == FixedArray::kHeaderSize);
+ STATIC_ASSERT(Context::kHeaderSize == FixedArray::kHeaderSize);
HValue* result =
Add<HLoadKeyed>(the_context, mapped_index,
static_cast<HValue*>(NULL),
FAST_ELEMENTS, ALLOW_RETURN_HOLE);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
