Reviewers: Sven Panne,

Message:
PTAL


https://codereview.chromium.org/792463003/diff/1/src/compiler/js-typed-lowering.h
File src/compiler/js-typed-lowering.h (left):

https://codereview.chromium.org/792463003/diff/1/src/compiler/js-typed-lowering.h#oldcode34
src/compiler/js-typed-lowering.h:34: Reduction ReplaceWith(Node* node) {
return Reducer::Replace(node); }
This is drive-by-cleanup.

Description:
[turbofan] Turn JSToBoolean and JSUnaryNot into pure operators.

Also fix the pushing of JSToBoolean into Phis and generalize it to
also include pushing into Selects.

TEST=cctest,unittests

Please review this at https://codereview.chromium.org/792463003/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+195, -114 lines):
  M src/compiler/arm/linkage-arm.cc
  M src/compiler/arm64/linkage-arm64.cc
  M src/compiler/change-lowering.cc
  M src/compiler/ia32/linkage-ia32.cc
  M src/compiler/js-generic-lowering.cc
  M src/compiler/js-graph.h
  M src/compiler/js-operator.cc
  M src/compiler/js-typed-lowering.h
  M src/compiler/js-typed-lowering.cc
  M src/compiler/linkage.h
  M src/compiler/linkage.cc
  M src/compiler/linkage-impl.h
  M src/compiler/mips/linkage-mips.cc
  M src/compiler/mips64/linkage-mips64.cc
  M src/compiler/raw-machine-assembler.cc
  M src/compiler/simplified-lowering.cc
  M src/compiler/x64/linkage-x64.cc
  M test/cctest/cctest.status
  M test/cctest/compiler/test-js-typed-lowering.cc
  M test/unittests/compiler/js-operator-unittest.cc
  M test/unittests/compiler/js-typed-lowering-unittest.cc


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to