lgtm
I'm not convinced of the "GYPFLAGS += .." in the Makefile, please have
another
look at it. All else looks good.
https://codereview.chromium.org/787033002/diff/1/Makefile
File Makefile (right):
https://codereview.chromium.org/787033002/diff/1/Makefile#newcode42
Makefile:42: GYPFLAGS += -Dv8_use_external_startup_data=1
This looks like a rather surprising difference between Makefile and gyp
or GN. Not sure that's a good idea....
https://codereview.chromium.org/787033002/diff/1/src/mksnapshot.cc
File src/mksnapshot.cc (right):
https://codereview.chromium.org/787033002/diff/1/src/mksnapshot.cc#newcode54
src/mksnapshot.cc:54: MaybeWriteStartupBlob(blob);
If we have one format for both, why would we need both the raw file and
the startup blob? Aren't they identical now?
(If so, I think the raw_file member, command line option, etc. can all
go.)
https://codereview.chromium.org/787033002/diff/1/src/mksnapshot.cc#newcode68
src/mksnapshot.cc:68: void MaybeWriteRawFile(const i::Vector<const
i::byte>& blob) const {
The two MaybeWrite* methods are identical except for naming. We probably
only need one method, even if we write both files.
https://codereview.chromium.org/787033002/diff/1/src/natives-external.cc
File src/natives-external.cc (right):
https://codereview.chromium.org/787033002/diff/1/src/natives-external.cc#newcode15
src/natives-external.cc:15: #endif // V8_USE_EXTERNAL_STARTUP_DATA
Good idea, thanks!
https://codereview.chromium.org/787033002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
