Status: Accepted
Owner: [email protected]
CC: [email protected], [email protected], [email protected]
Labels: Type-Bug Priority-Medium
New issue 3747 by [email protected]: FLAG_debug_code and emit_debug_code
may be used synonymously, even though they differ.
https://code.google.com/p/v8/issues/detail?id=3747
full-codegen is intialized with this:
void FullCodeGenerator::Initialize() {
InitializeAstVisitor(info_->zone());
// The generation of debug code must match between the snapshot code and
the
// code that is generated later. This is assumed by the debugger when it
is
// calculating PC offsets after generating a debug version of code.
Therefore
// we disable the production of debug code in the full compiler if we are
// either generating a snapshot or we booted from a snapshot.
generate_debug_code_ = FLAG_debug_code &&
!masm_->serializer_enabled() &&
!Snapshot::HaveASnapshotToStartFrom();
masm_->set_emit_debug_code(generate_debug_code_);
masm_->set_predictable_code_size(true);
}
However, we have uses of generate_debug_code_, emit_debug_code() and
FLAG_debug_code all across full-codegen. Note that FLAG_debug_code is
always true if --debug-code is specified, but the other two are only true
if we are not creating a snapshot or running on an isolate spawned from a
snapshot.
While I don't see any bug right now, it is concerning that the usage is
mixed and the intention in the comment in FullCodeGenerator::Initialize may
not be guaranteed.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
