Reviewers: Yang,
Description:
Fix messages tests.
Change tests so that message location is stable under --debug-code.
[email protected]
BUG=v8:3744
LOG=N
Please review this at https://codereview.chromium.org/792563003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -9 lines):
M test/message/message.status
M test/message/super-constructor.js
M test/message/super-constructor.out
M test/message/super-constructor-extra-statement.js
M test/message/super-constructor-extra-statement.out
Index: test/message/message.status
diff --git a/test/message/message.status b/test/message/message.status
index
5403f481a61c7994d0081e54a3467f0c4235a7e0..234bf0f35ca1b50c16f0aa3d1d10ef088d60c42d
100644
--- a/test/message/message.status
+++ b/test/message/message.status
@@ -30,9 +30,4 @@
# All tests in the bug directory are expected to fail.
'bugs/*': [FAIL],
}], # ALWAYS
-['no_snap == True', {
- # BUG(3744)
- 'super-constructor': [PASS,FAIL],
- 'super-constructor-extra-statement': [PASS,FAIL],
-}],
]
Index: test/message/super-constructor-extra-statement.js
diff --git a/test/message/super-constructor-extra-statement.js
b/test/message/super-constructor-extra-statement.js
index
a26381bf07471ad77526141a21385f58c6aa622b..e8ffe2dbfa59d66d59034b4a54b939565f4802e2
100644
--- a/test/message/super-constructor-extra-statement.js
+++ b/test/message/super-constructor-extra-statement.js
@@ -12,4 +12,4 @@ class C {
}
}
-new C();
+var c = new C();
Index: test/message/super-constructor-extra-statement.out
diff --git a/test/message/super-constructor-extra-statement.out
b/test/message/super-constructor-extra-statement.out
index
835508032ea559e6bc5cae77574d0b9b10248ee1..cbe1e0704f763bc5c3d9dcb6641eb13871068b6d
100644
--- a/test/message/super-constructor-extra-statement.out
+++ b/test/message/super-constructor-extra-statement.out
@@ -5,4 +5,4 @@
var x;
TypeError: A 'super' constructor call may only appear as the first
statement of a function, and its arguments may not access 'this'. Other
forms are not yet supported.
- at *%(basename)s:15:1
+ at *%(basename)s:15:9
Index: test/message/super-constructor.js
diff --git a/test/message/super-constructor.js
b/test/message/super-constructor.js
index
9c96d9bc34ada080b5a90e78fa9b8f967da5ca66..430dc58ce71b5cffc3150322eb91c408e5892ece
100644
--- a/test/message/super-constructor.js
+++ b/test/message/super-constructor.js
@@ -11,4 +11,4 @@ class C {
}
}
-new C();
+var c = new C();
Index: test/message/super-constructor.out
diff --git a/test/message/super-constructor.out
b/test/message/super-constructor.out
index
c60b0aa2c4768a5a5c80b90bcfdd7c32533236c4..bc3a699dbe9b235fa2e2e30b5a3fb4eeb7358571
100644
--- a/test/message/super-constructor.out
+++ b/test/message/super-constructor.out
@@ -5,4 +5,4 @@
super(this.x);
TypeError: A 'super' constructor call may only appear as the first
statement of a function, and its arguments may not access 'this'. Other
forms are not yet supported.
- at *%(basename)s:14:1
+ at *%(basename)s:14:9
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
