On 2014/12/09 22:42:15, caitp wrote:
https://codereview.chromium.org/663683006/diff/710001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/663683006/diff/710001/src/preparser.h#newcode2816
src/preparser.h:2816: int pos = peek_position();
On 2014/12/09 22:40:49, Dmitry Lomov (chromium) wrote:
> On 2014/12/09 22:37:13, brucedawson wrote:
> > While running VC++'s /analyze on Chrome I got a warning for this line
of
code,
> > pointing out that the definition of 'pos' shadows another definition
in
the
> > outer scope. These warnings are fairly common, but this one looks
potentially
> > wrong. The use of 'pos' in the ReportMessageAt call a few lines down
looks
> like
> > it might be intended to use the outer-scope pos. At the very least the
intent
> is
> > not clear.
> >
> > Any thoughts?
>
> The usage looks good (we are reporting the error from pos to
peek_position()
> which changes after we parse an expression.
We could rename it to avoid the warning, if that makes sense
Up to you Caitlin :) I am fine either way
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
