Reviewers: Sven Panne,
Description:
Use nobarrier load in store buffer duplicate removal to annotate harmless
race.
BUG=
Please review this at https://codereview.chromium.org/787383002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -1 lines):
M src/heap/store-buffer.cc
Index: src/heap/store-buffer.cc
diff --git a/src/heap/store-buffer.cc b/src/heap/store-buffer.cc
index
5fd4ce34f3aee6913c42fe3c292b1dea5f0ea8ab..eae3594a18a38b7e1b79803d3d72a9fedd55b278
100644
--- a/src/heap/store-buffer.cc
+++ b/src/heap/store-buffer.cc
@@ -109,7 +109,9 @@ void StoreBuffer::Uniq() {
for (Address* read = old_start_; read < old_top_; read++) {
Address current = *read;
if (current != previous) {
- if (heap_->InNewSpace(*reinterpret_cast<Object**>(current))) {
+ Object* object = reinterpret_cast<Object*>(
+
base::NoBarrier_Load(reinterpret_cast<base::AtomicWord*>(current)));
+ if (heap_->InNewSpace(object)) {
*write++ = current;
}
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
