lgtm.
Couple of minor comments that you can ignore if you want.
Thanks for implementing this.
https://codereview.chromium.org/786823003/diff/20001/src/third_party/fdlibm/fdlibm.cc
File src/third_party/fdlibm/fdlibm.cc (right):
https://codereview.chromium.org/786823003/diff/20001/src/third_party/fdlibm/fdlibm.cc#newcode85
src/third_party/fdlibm/fdlibm.cc:85: 5.99999999999994648725e-01, // L1
55 coefficients for log2
Nit: Certainly would be nice to add (or move) a comment to a new line
before line 85 saying these are for the log2 implementation. Same goes
for the other tables above now that there are so many entries.
https://codereview.chromium.org/786823003/diff/20001/src/third_party/fdlibm/fdlibm.js
File src/third_party/fdlibm/fdlibm.js (right):
https://codereview.chromium.org/786823003/diff/20001/src/third_party/fdlibm/fdlibm.js#newcode614
src/third_party/fdlibm/fdlibm.js:614: const KEXPM1_OVERFLOW = kMath[44];
I think it would be nice to have KEXPM1_TABLE_OFFSET (or something) that
gives the starting offset in the kMath table for all of the expm1
releated entries. Then you wouldn't have to change every one of these
offsets here and below.
https://codereview.chromium.org/786823003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
