Reviewers: Michael Achenbach,
Description:
Temporarily remove warning about inconsistent overrides
Otherwise, V8 won't compile with the latest clang anymore
BUG=v8:3753
[email protected]
LOG=n
Please review this at https://codereview.chromium.org/797583004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+8, -1 lines):
M build/standalone.gypi
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index
76fa7191eb54954e48ccd7439236cf0b94257d6c..bdb538d26c6755761ba66167e9ded5701208fc97
100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -232,6 +232,13 @@
],
},
}],
+ ['clang==1', {
+ 'target_defaults': {
+ # Remove once issue 3753 is fixed.
+ 'cflags_cc': [ '-Wno-inconsistent-missing-override',
+ '-Wno-unknown-warning-option' ],
+ },
+ }],
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
or OS=="netbsd"', {
'target_defaults': {
@@ -247,7 +254,7 @@
# Don't warn about the "struct foo f = {0};" initialization
pattern.
'-Wno-missing-field-initializers',
],
- 'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti', '-std=gnu++0x' ],
+ 'cflags_cc':
[ '-Wnon-virtual-dtor', '-fno-rtti', '-std=gnu++0x', '-Wnoinconsistent-missing-override'
],
'ldflags': [ '-pthread', ],
'conditions': [
[ 'visibility=="hidden" and v8_enable_backtrace==0', {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
