On 2014/12/01 20:11:22, caitp wrote:
https://codereview.chromium.org/769113002/diff/1/test/js-perf-test/Templates/Templates.json
File test/js-perf-test/Templates/Templates.json (right):
https://codereview.chromium.org/769113002/diff/1/test/js-perf-test/Templates/Templates.json#newcode6
test/js-perf-test/Templates/Templates.json:6: "run_count": 5,
On 2014/12/01 20:04:07, arv wrote:
> Try increasing this if the test is really fast
I don't think that solves the problem --- each step takes 1000ms to get
through
(we elapse like 30,000+ runs in each step) but the reporting for those
iterations never happens. It looked to me like if it doesn't get through
an
expected iteration count, it will report results, but if it does, it
won't. I
feel like it's a bug in the benchmark itself, but I'm not positive. (I've
tried
this with 100 steps instead of 5, same issue --- no results output).
So the materialized-literals-in-preparser thing fixed the segfault, and it's
working well now.
It would be good to measure the impact of hash collisions, and maybe add
some
more complicated tests, but the simple cases seem to score pretty highly.
Any suggestions for better benchmarks?
https://codereview.chromium.org/769113002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
