I really appreciate the effort you put into this, and from a first look, the
latest patch makes sense.
However, I'm fundamentally concerned about the fact that this change
introduces
a second, completely different mechanism for doing variable resolution. The
one
we have now is already more subtle than we'd like. Having to maintain two
different ones, and making sure that they stay in perfect sync, is probably
going to be very painful. Especially when there are no significant tests
even
checking that they are in sync.
So, while I wholeheartedly agree that this would be great to have (and your
numbers are very convincing!), I'm sorry to say that I don't think we want
to
land this patch in its current form. We would need to find a way to have a
sufficiently unified implementation (e.g., by factoring out the
commonalities of
Scope objects as well as the VariableResolution/Allocation algorithms
somehow).
https://codereview.chromium.org/641283003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
