[v8-dev] Log V8 version in profiler log file. (issue 800293002 by ben@strongloop.com)

[ben]

Reviewers: Yang,

Message:
Makes it possible to match tick processors to log files.
Description:
Log V8 version in profiler log file.

Please review this at https://codereview.chromium.org/800293002/

Affected files (+37, -0 lines):
  M src/log-utils.cc
  M test/cctest/test-log.cc


Index: src/log-utils.cc
diff --git a/src/log-utils.cc b/src/log-utils.cc
index  
c94d07a9f29220fab5caeb252381c35821f6970c..caada8bd2f2ee318618b2eea2660c4a15ae653a3  
100644
--- a/src/log-utils.cc
+++ b/src/log-utils.cc
@@ -6,6 +6,7 @@

 #include "src/log-utils.h"
 #include "src/string-stream.h"
+#include "src/version.h"

 namespace v8 {
 namespace internal {
@@ -49,6 +50,17 @@ void Log::Initialize(const char* log_file_name) {
     } else {
       OpenFile(log_file_name);
     }
+
+    if (output_handle_ != nullptr) {
+      Log::MessageBuilder msg(this);
+      msg.Append("v8-version,%d,%d,%d,%d,%d",
+                 Version::GetMajor(),
+                 Version::GetMinor(),
+                 Version::GetBuild(),
+                 Version::GetPatch(),
+                 Version::IsCandidate());
+      msg.WriteToLogFile();
+    }
   }
 }

Index: test/cctest/test-log.cc
diff --git a/test/cctest/test-log.cc b/test/cctest/test-log.cc
index  
6fe3a561b4d68ebd7ad3ddebc8d26fe625191206..cb47e2d60df81fafd6a90330b6caeb055809b570  
100644
--- a/test/cctest/test-log.cc
+++ b/test/cctest/test-log.cc
@@ -42,6 +42,7 @@
 #include "src/natives.h"
 #include "src/utils.h"
 #include "src/v8threads.h"
+#include "src/version.h"
 #include "src/vm-state-inl.h"
 #include "test/cctest/cctest.h"

@@ -507,3 +508,27 @@ TEST(EquivalenceOfLoggingAndTraversal) {
   }
   isolate->Dispose();
 }
+
+
+TEST(LogVersion) {
+  v8::Isolate* isolate;
+  {
+    ScopedLoggerInitializer initialize_logger;
+    isolate = initialize_logger.isolate();
+    bool exists = false;
+    i::Vector<const char> log(
+        i::ReadFile(initialize_logger.StopLoggingGetTempFile(), &exists,  
true));
+    CHECK(exists);
+    i::EmbeddedVector<char, 100> ref_data;
+    i::SNPrintF(ref_data,
+                "v8-version,%d,%d,%d,%d,%d",
+                i::Version::GetMajor(),
+                i::Version::GetMinor(),
+                i::Version::GetBuild(),
+                i::Version::GetPatch(),
+                i::Version::IsCandidate());
+    CHECK_NE(NULL, StrNStr(log.start(), ref_data.start(), log.length()));
+    log.Dispose();
+  }
+  isolate->Dispose();
+}


--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.