Comment #3 on issue 3745 by [email protected]: Object.observe should not get notifications about changes to API accessor properties
https://code.google.com/p/v8/issues/detail?id=3745#c3

The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/a32291fa1fee4d90ec299bf1e0d5a65e97eeb352

commit a32291fa1fee4d90ec299bf1e0d5a65e97eeb352
Author: adamk <[email protected]>
Date: Fri Dec 12 18:15:43 2014

Stop sending Object.observe notifications for API accessor properties

Such properties never notified prior to r21558, but the combination of
that change and r23163 led to sending notifications when they were
set via Object.defineProperty (but not when set via other means).

This also allows some cleanup in v8natives.js and objects.cc,
both of which were doing unnecessary contortions to produce the right
change records.

BUG=v8:3745
LOG=n

Review URL: https://codereview.chromium.org/791243002

Cr-Commit-Position: refs/heads/master@{#25806}

[modify] http://crrev.com/a32291fa1fee4d90ec299bf1e0d5a65e97eeb352/src/objects.cc [modify] http://crrev.com/a32291fa1fee4d90ec299bf1e0d5a65e97eeb352/src/v8natives.js [modify] http://crrev.com/a32291fa1fee4d90ec299bf1e0d5a65e97eeb352/test/cctest/test-object-observe.cc


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to