Comment #3 on issue 3167 by [email protected]: Keyed loads shouldn't
deopt on non-number keys that they've seen before
https://code.google.com/p/v8/issues/detail?id=3167#c3
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/f6e68d2c2c1e92c14f220223f4a0b54b54aadff6
commit f6e68d2c2c1e92c14f220223f4a0b54b54aadff6
Author: fedor.indutny <[email protected]>
Date: Mon Dec 15 13:36:13 2014
Hydrogen: fix keyed loads with string keys
Keyed loads should not unconditionally be compiled to element loads. Update
KeyedLoadICs to keep track of the key type, so that Hydrogen can emit ICs
for string-keyed loads it doesn't have inline support for.
BUG=v8:3167
[email protected]
Review URL: https://codereview.chromium.org/755513003
Cr-Commit-Position: refs/heads/master@{#25817}
[modify] http://crrev.com/f6e68d2c2c1e92c14f220223f4a0b54b54aadff6/src/ast.h
[modify]
http://crrev.com/f6e68d2c2c1e92c14f220223f4a0b54b54aadff6/src/hydrogen.cc
[modify]
http://crrev.com/f6e68d2c2c1e92c14f220223f4a0b54b54aadff6/src/ic/ic-compiler.cc
[modify]
http://crrev.com/f6e68d2c2c1e92c14f220223f4a0b54b54aadff6/src/ic/ic.h
[modify]
http://crrev.com/f6e68d2c2c1e92c14f220223f4a0b54b54aadff6/src/type-info.cc
[modify]
http://crrev.com/f6e68d2c2c1e92c14f220223f4a0b54b54aadff6/src/type-info.h
[modify]
http://crrev.com/f6e68d2c2c1e92c14f220223f4a0b54b54aadff6/src/typing.cc
[add]
http://crrev.com/f6e68d2c2c1e92c14f220223f4a0b54b54aadff6/test/mjsunit/keyed-load-with-string-key.js
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
