On 2014/12/15 14:21:59, Sven Panne wrote:
https://codereview.chromium.org/803993002/diff/1/src/zone-containers.h
File src/zone-containers.h (right):
https://codereview.chromium.org/803993002/diff/1/src/zone-containers.h#newcode92
src/zone-containers.h:92: struct PtrRange {
Drive-by nit-pick: If performance (i.e. the copying of the range) is not
an
issue (it's just for test if I see this correctly), this class is
unnecessary:
Just use the range constructor of e.g. vector. Furthermore,
CheckRangeContains
is basically std:find then.
Yes, I considered doing that, but the problem is that nested loops can give
rise
to worst case O(n^2) space, so that's the reason for the careful
overlapping of
intervals. In graphs with 50,000 nodes and 30+ loops, it that could be
extreme
:)
https://codereview.chromium.org/803993002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
