https://codereview.chromium.org/794583003/diff/60001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/794583003/diff/60001/src/heap/mark-compact.cc#newcode2134
src/heap/mark-compact.cc:2134: // down to Map::kRetainingCounterStart.
This range can be narrowed
Comment looks wrong.
https://codereview.chromium.org/794583003/diff/60001/src/heap/mark-compact.cc#newcode2269
src/heap/mark-compact.cc:2269: RetainMaps(&root_visitor);
This should be after the ephemeral stuff. Maps that are kept alive by
ephemerally-alive objects should not age.
But even better would be to put it inside ClearNonLiveReferences. That
already iterates over the map space. It is better for the cache not to
iterate multiple times.
https://codereview.chromium.org/794583003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
