lgtm % 3 nits
https://codereview.chromium.org/811073002/diff/20001/tools/push-to-trunk/check_clusterfuzz.py
File tools/push-to-trunk/check_clusterfuzz.py (right):
https://codereview.chromium.org/811073002/diff/20001/tools/push-to-trunk/check_clusterfuzz.py#newcode43
tools/push-to-trunk/check_clusterfuzz.py:43: # List of all api requests
nit: missing period at the end.
https://codereview.chromium.org/811073002/diff/20001/tools/push-to-trunk/check_clusterfuzz.py#newcode83
tools/push-to-trunk/check_clusterfuzz.py:83: commits =
json.loads(result[5:])
this constant bothers me, but if you are sure of 5, let it be :)
https://codereview.chromium.org/811073002/diff/20001/tools/push-to-trunk/check_clusterfuzz.py#newcode117
tools/push-to-trunk/check_clusterfuzz.py:117: conn.request("POST",
"/_api/", params, headers)
can this raise exception and log the URL? If so, it'd leak your api_key
.
I tried to break it, but only exceptions I get are socket errors, and
they don't leak data. Still, maybe wrap it in try, finally just in case?
https://codereview.chromium.org/811073002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
