On 2014/12/17 20:03:33, Jakob wrote:
DBC:
(1) When relanding, recommended practice is to upload the original patch
as a
first patch set, then any modifications as subsequent patch sets. That
way,
reviewers can easily tell what's changed.
That's a good idea. I'll do that next time.
(2) IIRC, the plan was to implement all ES6 features such that a simple
flag
flip is enough to turn them off if the need arises. It would appear that
following this principle would also avoid the churn of repeatedly
landing/reverting 1000+ line patches, and at the same time test that the
emergency off switch works ;-)
This is under a flag that is off by default. The crash is in a test that
tests
the new feature. We could keep the code and just disable the test but then
we
would have a large chunk of code that is not being tested which is also bad.
https://codereview.chromium.org/792233008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
