lgtm
https://codereview.chromium.org/812583003/diff/60001/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):
https://codereview.chromium.org/812583003/diff/60001/test/cctest/test-debug.cc#newcode7403
test/cctest/test-debug.cc:7403: void Run() override {
Use OVERRIDE, not all our toolchains support override yet.
https://codereview.chromium.org/812583003/diff/60001/test/cctest/test-debug.cc#newcode7417
test/cctest/test-debug.cc:7417: void Run() override {
Same here.
https://codereview.chromium.org/812583003/diff/60001/test/cctest/test-debug.cc#newcode7432
test/cctest/test-debug.cc:7432: // loop is already running.
Remove the comment, there's no delay anymore.
https://codereview.chromium.org/812583003/diff/60001/test/cctest/test-debug.cc#newcode7436
test/cctest/test-debug.cc:7436: CompileRun("while (!stop) {}");
Well, without any kind of handshake (via a native function), the test
itself might not be flaky, but the thing it tests is. In a nutshell: Our
test coverage is flaky now, but if that's OK for you...
https://codereview.chromium.org/812583003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
