https://codereview.chromium.org/812353002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/812353002/diff/1/src/hydrogen.cc#newcode3068
src/hydrogen.cc:3068:
builder.If<HCompareObjectEqAndBranch>(expected_map, map);
On 2014/12/18 15:21:07, Jakob wrote:
nit: When several IfBuilders are at play, I like naming them by
purpose, e.g.
"if_map_matches" or "map_check". Also, the builder sequence can be
made shorter
and more readable:
IfBuilder map_check(this);
map_check.IfNot<HCompareObjectEqAndBranch>(expected_map, map);
map_check.ThenDeopt("Unknown map");
map_check.End();
Done. Thanks, this is much better.
https://codereview.chromium.org/812353002/diff/1/src/hydrogen.cc#newcode3073
src/hydrogen.cc:3073: } else {
On 2014/12/18 15:21:07, Jakob wrote:
nit: add a DCHECK(map_embedding == kEmbedMapsDirectly) as the first
line of the
else-block, for documentation.
Done.
https://codereview.chromium.org/812353002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
