https://codereview.chromium.org/812163003/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/812163003/diff/1/src/preparser.h#newcode2849
src/preparser.h:2849: CheckOctalLiteral(pos, peek_position(), CHECK_OK);
On 2014/12/18 20:38:51, arv wrote:
CheckOctalLiteral needs to be updated to use a different error
message.
Yeah --- I was undecided whether it should be something generic like
"Octal escape sequences are deprecated", or let callers pass in their
own message ID and make a template-specific error message.
What do you think?
https://codereview.chromium.org/812163003/diff/1/test/mjsunit/harmony/templates.js
File test/mjsunit/harmony/templates.js (right):
https://codereview.chromium.org/812163003/diff/1/test/mjsunit/harmony/templates.js#newcode482
test/mjsunit/harmony/templates.js:482: code = "(function(){})" + code;
On 2014/12/18 20:38:51, arv wrote:
Why do we need a tagged version here?
When testing, I ran into issues when calling CheckOctalLiteral() because
I was sending the wrong positions, so I thought it would be good to
check this case too just in case something changes there, since it was a
bit finicky to make it work.
https://codereview.chromium.org/812163003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
