Bill, my stance: if one often converts a string, or randomly access chars, etc., it is a good idea to flatten string. However that shouldn't be a default behaviour if you only want to serialize a string into external buffer.
And I don't think it has n^2 behaviour: you just move/compare tons of chars several times. yours, anton. On Tue, Oct 20, 2009 at 1:04 PM, <[email protected]> wrote: > LGTM, but is there still a problem with converting cons strings using > ToCString? > This method should not be this slow, so avoiding the call to it just > targets > the symptoms, not the disease. Does this have n^2 behavior? > > http://codereview.chromium.org/294019 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
