Reviewers: Sven Panne,
Description:
Print the SharedFunctionInfo besides the function name, makes matching
against
--trace_opt output easier.
Please review this at https://codereview.chromium.org/816013002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -8 lines):
M src/deoptimizer.cc
Index: src/deoptimizer.cc
diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc
index
554ba8e7b17f272e5f4dbfbad51df460343bcc8a..5e47b3294062a5fdab63f8f8b7d3332821f767a6
100644
--- a/src/deoptimizer.cc
+++ b/src/deoptimizer.cc
@@ -637,7 +637,7 @@ Code* Deoptimizer::FindOptimizedCode(JSFunction*
function,
void Deoptimizer::PrintFunctionName() {
if (function_->IsJSFunction()) {
- function_->PrintName(trace_scope_->file());
+ function_->ShortPrint();
} else {
PrintF(trace_scope_->file(),
"%s", Code::Kind2String(compiled_code_->kind()));
@@ -762,9 +762,8 @@ void Deoptimizer::DoComputeOutputFrames() {
if (trace_scope_ != NULL) {
timer.Start();
PrintF(trace_scope_->file(),
- "[deoptimizing (DEOPT %s): begin 0x%08" V8PRIxPTR " ",
- MessageFor(bailout_type_),
- reinterpret_cast<intptr_t>(function_));
+ "[deoptimizing (DEOPT %s): begin ",
+ MessageFor(bailout_type_));
PrintFunctionName();
PrintF(trace_scope_->file(),
" (opt #%d) @%d, FP to SP delta: %d]\n",
@@ -850,11 +849,9 @@ void Deoptimizer::DoComputeOutputFrames() {
if (trace_scope_ != NULL) {
double ms = timer.Elapsed().InMillisecondsF();
int index = output_count_ - 1; // Index of the topmost frame.
- JSFunction* function = output_[index]->GetFunction();
PrintF(trace_scope_->file(),
- "[deoptimizing (%s): end 0x%08" V8PRIxPTR " ",
- MessageFor(bailout_type_),
- reinterpret_cast<intptr_t>(function));
+ "[deoptimizing (%s): end ",
+ MessageFor(bailout_type_));
PrintFunctionName();
PrintF(trace_scope_->file(),
" @%d => node=%d, pc=0x%08" V8PRIxPTR ", state=%s,
alignment=%s,"
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
