Reviewers: Benedikt Meurer,
Description:
Keep AllocationSpace and ObjectSpace enums in sync.
BUG=
Please review this at https://codereview.chromium.org/806693011/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+14, -12 lines):
M include/v8.h
M src/globals.h
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
b34f43a7cce634e76d5932f26c07b6ddfe5d2cf1..0acedfdb14af11246e3102c58f0aa5d29cae55f4
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4401,18 +4401,19 @@ typedef void* (*CreateHistogramCallback)(const
char* name,
typedef void (*AddHistogramSampleCallback)(void* histogram, int sample);
// --- Memory Allocation Callback ---
- enum ObjectSpace {
- kObjectSpaceNewSpace = 1 << 0,
- kObjectSpaceOldPointerSpace = 1 << 1,
- kObjectSpaceOldDataSpace = 1 << 2,
- kObjectSpaceCodeSpace = 1 << 3,
- kObjectSpaceMapSpace = 1 << 4,
- kObjectSpaceLoSpace = 1 << 5,
-
- kObjectSpaceAll = kObjectSpaceNewSpace | kObjectSpaceOldPointerSpace |
- kObjectSpaceOldDataSpace | kObjectSpaceCodeSpace |
kObjectSpaceMapSpace |
- kObjectSpaceLoSpace
- };
+enum ObjectSpace {
+ kObjectSpaceNewSpace = 1 << 0,
+ kObjectSpaceOldPointerSpace = 1 << 1,
+ kObjectSpaceOldDataSpace = 1 << 2,
+ kObjectSpaceCodeSpace = 1 << 3,
+ kObjectSpaceMapSpace = 1 << 4,
+ kObjectSpaceCellSpace = 1 << 5,
+ kObjectSpacePropertyCellSpace = 1 << 6,
+ kObjectSpaceLoSpace = 1 << 7,
+ kObjectSpaceAll = kObjectSpaceNewSpace | kObjectSpaceOldPointerSpace |
+ kObjectSpaceOldDataSpace | kObjectSpaceCodeSpace |
+ kObjectSpaceMapSpace | kObjectSpaceLoSpace
+};
enum AllocationAction {
kAllocationActionAllocate = 1 << 0,
Index: src/globals.h
diff --git a/src/globals.h b/src/globals.h
index
8c27b01b545bf35c4778571b07fd9a5efaeb4680..23d465c45b7bcef92e8df2d1325912972a396212
100644
--- a/src/globals.h
+++ b/src/globals.h
@@ -348,6 +348,7 @@ typedef bool (*WeakSlotCallbackWithHeap)(Heap* heap,
Object** pointer);
// NOTE: SpaceIterator depends on AllocationSpace enumeration values being
// consecutive.
+// Keep this enum in sync with the ObjectSpace enum in v8.h
enum AllocationSpace {
NEW_SPACE, // Semispaces collected with copying collector.
OLD_POINTER_SPACE, // May contain pointers to new space.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
