https://codereview.chromium.org/816363003/diff/1/src/optimizing-compiler-thread.cc
File src/optimizing-compiler-thread.cc (right):
https://codereview.chromium.org/816363003/diff/1/src/optimizing-compiler-thread.cc#newcode18
src/optimizing-compiler-thread.cc:18: static void
DisposeOptimizedCompileJob(OptimizedCompileJob* job,
Nit: use anonymous namespace instead of static here.
https://codereview.chromium.org/816363003/diff/1/src/optimizing-compiler-thread.h
File src/optimizing-compiler-thread.h (right):
https://codereview.chromium.org/816363003/diff/1/src/optimizing-compiler-thread.h#newcode144
src/optimizing-compiler-thread.h:144: base::RecursiveMutex
task_count_mutex_;
Why RecursiveMutex? Can we have a normal mutex instead?
https://codereview.chromium.org/816363003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
