Revision: 3092 Author: [email protected] Date: Tue Oct 20 05:13:31 2009 Log: Fix issue 475
The check for arguments in registers in one of the three versions of GenericBinaryOpStub::GenerateCall was plain wrong. BUG=475 TEST=mjsunit/regress/regress-475.js Review URL: http://codereview.chromium.org/307002 http://code.google.com/p/v8/source/detail?r=3092 Added: /branches/bleeding_edge/test/mjsunit/regress/regress-475.js Modified: /branches/bleeding_edge/src/ia32/codegen-ia32.cc ======================================= --- /dev/null +++ /branches/bleeding_edge/test/mjsunit/regress/regress-475.js Tue Oct 20 05:13:31 2009 @@ -0,0 +1,28 @@ +// Copyright 2009 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +assertEquals(1, (function (){return 1|-1%1})()); ======================================= --- /branches/bleeding_edge/src/ia32/codegen-ia32.cc Wed Oct 14 06:12:38 2009 +++ /branches/bleeding_edge/src/ia32/codegen-ia32.cc Tue Oct 20 05:13:31 2009 @@ -6531,7 +6531,7 @@ Register left, Register right) { if (!ArgsInRegistersSupported()) { - // Only pass arguments in registers if there is no smi code in the stub. + // Pass arguments on the stack. __ push(left); __ push(right); } else { @@ -6584,7 +6584,7 @@ Register left, Smi* right) { if (!ArgsInRegistersSupported()) { - // Only pass arguments in registers if there is no smi code in the stub. + // Pass arguments on the stack. __ push(left); __ push(Immediate(right)); } else { @@ -6612,8 +6612,8 @@ MacroAssembler* masm, Smi* left, Register right) { - if (flags_ != NO_SMI_CODE_IN_STUB) { - // Only pass arguments in registers if there is no smi code in the stub. + if (!ArgsInRegistersSupported()) { + // Pass arguments on the stack. __ push(Immediate(left)); __ push(right); } else { --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
