Done. Requires fixes to handle -0 correctly in the type system.
https://codereview.chromium.org/829303002/diff/20001/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/829303002/diff/20001/src/compiler/js-typed-lowering.cc#newcode930
src/compiler/js-typed-lowering.cc:930: // result value and can simply
replace the node if it's eliminatable.
On 2015/01/05 09:41:21, jarin wrote:
eliminatable -> eliminable?
Done.
https://codereview.chromium.org/829303002/diff/20001/test/unittests/compiler/js-typed-lowering-unittest.cc
File test/unittests/compiler/js-typed-lowering-unittest.cc (right):
https://codereview.chromium.org/829303002/diff/20001/test/unittests/compiler/js-typed-lowering-unittest.cc#newcode85
test/unittests/compiler/js-typed-lowering-unittest.cc:85: }
On 2015/01/05 09:41:21, jarin wrote:
Could we have test checking that type 0 <union> -0 is not reduced?
Done.
https://codereview.chromium.org/829303002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
