Reviewers: jochen (OOO aka really slow),
Description:
Hack around broken snapshot generation in the GN build on Android.
The generated snapshot just crashes on the device, but
disabling snapshots allows us to run V8 just fine which
is sufficient for our purposes at this point.
Mojo/Sky are GN-only so we depend on the V8 GN build even if
it's not considered production for Chromium yet.
[email protected]
Please review this at https://codereview.chromium.org/832413005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -1 lines):
M BUILD.gn
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index
6534eea85948104dffd43635282a3d14f370bc82..403914476116cbdb93fc6c2056b0304b03c772eb
100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -17,7 +17,8 @@ v8_enable_verify_heap = false
v8_interpreted_regexp = false
v8_object_print = false
v8_postmortem_support = false
-v8_use_snapshot = true
+# TODO(eseidel): The snapshot generated by the GN Android build crashes.
+v8_use_snapshot = !is_android
v8_enable_extra_checks = is_debug
v8_target_arch = cpu_arch
v8_random_seed = "314159265"
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
