LGTM with nits
https://codereview.chromium.org/808333005/diff/1/src/ia32/assembler-ia32.cc
File src/ia32/assembler-ia32.cc (right):
https://codereview.chromium.org/808333005/diff/1/src/ia32/assembler-ia32.cc#newcode71
src/ia32/assembler-ia32.cc:71: // Make sure the buffer is 0-terminated.
System information of type "string" is always zero-terminated, so we can
remove this clutter. If the buffer was too small, we get ENOMEM, see
https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man3/sysctl.3.html.
https://codereview.chromium.org/808333005/diff/1/src/x64/assembler-x64.cc
File src/x64/assembler-x64.cc (right):
https://codereview.chromium.org/808333005/diff/1/src/x64/assembler-x64.cc#newcode37
src/x64/assembler-x64.cc:37: // Make sure the buffer is 0-terminated.
Same here.
https://codereview.chromium.org/808333005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
