lgtm
https://codereview.chromium.org/788043005/diff/220001/src/runtime/runtime-regexp.cc
File src/runtime/runtime-regexp.cc (right):
https://codereview.chromium.org/788043005/diff/220001/src/runtime/runtime-regexp.cc#newcode825
src/runtime/runtime-regexp.cc:825: case 'u':
Nit: sort cases alphabetically
https://codereview.chromium.org/788043005/diff/220001/test/mjsunit/harmony/unicode-escapes-in-regexps.js
File test/mjsunit/harmony/unicode-escapes-in-regexps.js (right):
https://codereview.chromium.org/788043005/diff/220001/test/mjsunit/harmony/unicode-escapes-in-regexps.js#newcode145
test/mjsunit/harmony/unicode-escapes-in-regexps.js:145: new
RegExp("\\u{110000}")
Perhaps add the case
assertThrows{"new RegExp('\\\\u{1f}')", SyntaxError)
https://codereview.chromium.org/788043005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
