Reviewers: rossberg,
Message:
PTAL
Description:
Unship ES6 classes.
[email protected]
BUG=v8:3330
Please review this at https://codereview.chromium.org/836393003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+7, -6 lines):
M src/flag-definitions.h
M test/webkit/fast/js/Object-getOwnPropertyNames.js
M test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
0dd4fda05d5840c0dfc2535a023900da2f7097f1..dbc1b9c56584ac40d5e0d088c27f578a320e11e3
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -183,16 +183,17 @@ DEFINE_IMPLICATION(es_staging, harmony)
V(harmony_unicode, "harmony unicode escapes")
// Features that are complete (but still behind --harmony/es-staging flag).
-#define HARMONY_STAGED(V) V(harmony_tostring, "harmony toString")
+#define HARMONY_STAGED(V) \
+ V(harmony_tostring, "harmony toString") \
+ V(harmony_classes, \
+ "harmony classes (implies block scoping & object literal extension)") \
+ V(harmony_object_literals, "harmony object literal extensions")
// Features that are shipping (turned on by default, but internal flag
remains).
#define HARMONY_SHIPPING(V) \
V(harmony_numeric_literals, "harmony numeric literals") \
V(harmony_strings, "harmony string methods") \
V(harmony_scoping, "harmony block scoping") \
- V(harmony_classes, \
- "harmony classes (implies block scoping & object literal extension)") \
- V(harmony_object_literals, "harmony object literal extensions") \
V(harmony_templates, "harmony template literals")
// Once a shipping feature has proved stable in the wild, it will be
dropped
Index: test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
diff --git a/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
b/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
index
c96c8361fd559ab0fd32b27d1e069a31acb06d8c..0e00f23cadfde2cf4dcdef345390d1e740b7a10c
100644
--- a/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
+++ b/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
@@ -47,7 +47,7 @@ PASS getSortedOwnPropertyNames(encodeURIComponent) is
['arguments', 'caller', 'l
PASS getSortedOwnPropertyNames(Object) is
['arguments', 'caller', 'create', 'defineProperties', 'defineProperty', 'deliverChangeRecords', 'freeze', 'getNotifier', 'getOwnPropertyDescriptor', 'getOwnPropertyNames', 'getOwnPropertySymbols', 'getPrototypeOf', 'is', 'isExtensible', 'isFrozen', 'isSealed', 'keys', 'length', 'name', 'observe', 'preventExtensions', 'prototype', 'seal', 'setPrototypeOf', 'unobserve']
PASS getSortedOwnPropertyNames(Object.prototype) is
['__defineGetter__', '__defineSetter__', '__lookupGetter__', '__lookupSetter__', '__proto__', 'constructor', 'hasOwnProperty', 'isPrototypeOf', 'propertyIsEnumerable', 'toLocaleString', 'toString', 'valueOf']
PASS getSortedOwnPropertyNames(Function) is
['arguments', 'caller', 'length', 'name', 'prototype']
-PASS getSortedOwnPropertyNames(Function.prototype) is
['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toMethod', 'toString']
+PASS getSortedOwnPropertyNames(Function.prototype) is
['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString']
PASS getSortedOwnPropertyNames(Array) is
['arguments', 'caller', 'isArray', 'length', 'name', 'observe', 'prototype', 'unobserve']
PASS getSortedOwnPropertyNames(Array.prototype) is
['concat', 'constructor', 'entries', 'every', 'filter', 'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift']
PASS getSortedOwnPropertyNames(String) is
['arguments', 'caller', 'fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype', 'raw']
Index: test/webkit/fast/js/Object-getOwnPropertyNames.js
diff --git a/test/webkit/fast/js/Object-getOwnPropertyNames.js
b/test/webkit/fast/js/Object-getOwnPropertyNames.js
index
46d796666472f07240acede40a11be4d14aeda56..72bd21b4262c81cde234131f0572d3299be1387f
100644
--- a/test/webkit/fast/js/Object-getOwnPropertyNames.js
+++ b/test/webkit/fast/js/Object-getOwnPropertyNames.js
@@ -74,7 +74,7 @@ var expectedPropertyNamesSet = {
"Object": "['arguments', 'caller', 'create', 'defineProperties',
'defineProperty', 'deliverChangeRecords', 'freeze', 'getNotifier', 'getOwnPropertyDescriptor',
'getOwnPropertyNames', 'getOwnPropertySymbols', 'getPrototypeOf', 'is', 'isExtensible', 'isFrozen',
'isSealed', 'keys', 'length', 'name', 'observe', 'preventExtensions', 'prototype', 'seal',
'setPrototypeOf', 'unobserve']",
"Object.prototype": "['__defineGetter__', '__defineSetter__',
'__lookupGetter__', '__lookupSetter__', '__proto__', 'constructor', 'hasOwnProperty',
'isPrototypeOf', 'propertyIsEnumerable', 'toLocaleString', 'toString', 'valueOf']",
"Function": "['arguments', 'caller', 'length', 'name', 'prototype']",
- "Function.prototype": "['apply', 'arguments', 'bind', 'call', 'caller',
'constructor', 'length', 'name', 'toMethod', 'toString']",
+ "Function.prototype": "['apply', 'arguments', 'bind', 'call', 'caller',
'constructor', 'length', 'name', 'toString']",
"Array": "['arguments', 'caller', 'isArray', 'length', 'name', 'observe',
'prototype', 'unobserve']",
"Array.prototype": "['concat', 'constructor', 'entries', 'every', 'filter',
'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce',
'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString',
'unshift']",
"String": "['arguments', 'caller', 'fromCharCode', 'fromCodePoint', 'length',
'name', 'prototype', 'raw']",
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
