Most comments from ic-ia32 also apply to ic-x64.
http://codereview.chromium.org/294022/diff/1002/10 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/294022/diff/1002/10#newcode371 Line 371: __ movzx_b(ebx, FieldOperand(edx, Map::kBitFieldOffset)); Depending on how much performance this costs we could alternatively forbid access checks on objects with external array elements. http://codereview.chromium.org/294022/diff/1002/10#newcode394 Line 394: __ j(above_equal, &slow); What about negative indices? http://codereview.chromium.org/294022/diff/1002/10#newcode421 Line 421: ASSERT(false); UNREACHABLE() http://codereview.chromium.org/294022/diff/1002/10#newcode443 Line 443: ASSERT(array_type == kExternalUnsignedIntArray); ASSERT_EQ http://codereview.chromium.org/294022/diff/1002/10#newcode679 Line 679: __ j(above_equal, &slow); Negative? http://codereview.chromium.org/294022/diff/1002/10#newcode726 Line 726: __ fld_d(FieldOperand(eax, HeapNumber::kValueOffset)); Please add a comment about how this handles NaN, Infinity and other odd values. http://codereview.chromium.org/294022 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
