https://codereview.chromium.org/809333002/diff/130001/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/809333002/diff/130001/src/compiler/instruction-selector.cc#newcode467
src/compiler/instruction-selector.cc:467: // TODO(turbofan): only
reverse if > 1 instruction emitted.
On 2015/01/11 11:50:22, Benedikt Meurer wrote:
std::reverse handles that efficiently. No need to duplicate the work
in our
code. Remove this TODO.
Hopefully so, TODO removed.
https://codereview.chromium.org/809333002/diff/130001/src/compiler/instruction-selector.cc#newcode688
src/compiler/instruction-selector.cc:688: return VisitOsrValue(node);
On 2015/01/11 11:50:22, Benedikt Meurer wrote:
Missing MarkAsReference(node) here.
Done.
https://codereview.chromium.org/809333002/diff/130001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/809333002/diff/130001/src/compiler/pipeline.cc#newcode863
src/compiler/pipeline.cc:863: Run<OsrDeconstructionPhase>();
On 2015/01/11 11:50:22, Benedikt Meurer wrote:
Hm, can't we make the OSR deconstruction part of the late control
reduction?
As discussed in person, deconstruction will require a bit of loop
peeling before the control reduction, so it's still probably a good idea
to encapsulate it in OsrHelper.
If we make ControlReducer into a real reducer, it will be easier to
maybe make the Osr deconstruction a reducer that gets mixed in with the
late control reducer.
https://codereview.chromium.org/809333002/diff/130001/test/cctest/compiler/test-osr.cc
File test/cctest/compiler/test-osr.cc (right):
https://codereview.chromium.org/809333002/diff/130001/test/cctest/compiler/test-osr.cc#newcode36
test/cctest/compiler/test-osr.cc:36: static Operator
kIntLt(IrOpcode::kInt32LessThan, Operator::kPure,
On 2015/01/12 05:36:27, Benedikt Meurer wrote:
Why not use the MachineOperatorBuilder instead?
I think we should add a TestOperatorBuilder, since the actual operator
isn't that important in the test. It was just nice to see when the graph
was printed out. What do think?
https://codereview.chromium.org/809333002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
