The variable names in this code is indeed confusing. I changed the names and I think it is a bit better now.
Could you have another quick look? http://codereview.chromium.org/300036/diff/3001/3005 File src/flag-definitions.h (right): http://codereview.chromium.org/300036/diff/3001/3005#newcode168 Line 168: "max size of (each semispace in) the new generation") It wasn't, but it is in the latest snapshot. :) http://codereview.chromium.org/300036/diff/3001/3007 File src/heap.h (right): http://codereview.chromium.org/300036/diff/3001/3007#newcode254 Line 254: return 2 * young_generation_size_ + old_generation_size_; This method is only used to setup the virtual memory abstraction so it is important that this returns the max reserved amount of memory. Change the name to MaxReserved. http://codereview.chromium.org/300036 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
