https://codereview.chromium.org/849103007/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/849103007/diff/1/src/arm/code-stubs-arm.cc#newcode4699
src/arm/code-stubs-arm.cc:4699: __ add(scratch, scratch,
Operand(length_value, LSL, 2));
2 should be kPointerSizeLog2
https://codereview.chromium.org/849103007/diff/1/src/arm/code-stubs-arm.cc#newcode4700
src/arm/code-stubs-arm.cc:4700: __ add(scratch, scratch,
Operand((FCA::kArgsLength - 1) * kPointerSize));
should be able to do this with fused add multiply, no?
https://codereview.chromium.org/849103007/diff/1/src/arm/code-stubs-arm.cc#newcode4714
src/arm/code-stubs-arm.cc:4714: __ mov(ip, Operand(length_value, LSL,
3));
3 should be kPointerSizeLog2 + 1 to make it clear where it comes from
https://codereview.chromium.org/849103007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
